Support Neoforge #2548
Merged
Support Neoforge #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack installl page
…Image FXUtils.newBuiltinImage is used to load image which is supposed to be correct definitely and is a file within the jar. Or, it will throw ResourceNotFoundError. FXUtils.newRemoteImage is used to load image from the internet. It will cache the data of images for the further usage. The cached data will be deleted when HMCL is closed or hidden.
|
你好，NeoForge！ |
Closed
|
dynamic-remote-resource 是做什么的？ |
请先查看 Enhance Mod Download PR，其中有对这一系列更改的介绍 |
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/game/HMCLGameRepository.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/InstallerItem.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DownloadPage.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java # HMCLCore/src/main/java/org/jackhuang/hmcl/download/LibraryAnalyzer.java # HMCLCore/src/main/java/org/jackhuang/hmcl/mod/ModLoaderType.java
|
NeoForge 的安装器已定稿，应该不会有什么大变化，可以审查代码并合并了。 |
Closed
…ch has leading string 'neoforge-'.
huanghongxun
requested changes
Jan 7, 2024
HMCL/src/main/java/org/jackhuang/hmcl/setting/VersionIconType.java
Outdated
Show resolved
Hide resolved
|
代码里面一会儿NeoForge一会儿NeoForged会导致潜在bug，选择一种统一写法。 |
|
NeoForged 官方也在混用这两种称呼…… 代码里我都清理为 NeoForge 了，但那些 API 啥的，我保留不动，这个没办法 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2509 Close #2406 Close #2602